Refactor Material build method
#147430
Refactor Material build method
#147430
Conversation
github-actions
bot
added
framework
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #147430 at sha d6dde8a7336c333b2680e1681e60506ec8f672f1 |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
test-exempt: code refactor with no semantic change |
nate-thegrate
force-pushed
the
refactor-material-build
branch
from
1728bd7
to
f27690c
Compare
Only a code quality change, improves readability using `switch`.
I made a lot of random tweaks while working on issue #147392, so I thought it'd be good to file these changes as a separate pull request so that eventually the main PR will be easier to review.
Currently, the
Materialbuild method makes multiple calls toTheme.of(context), and_MaterialInteriorhas a nullableshadowColor(even though the values passed to it are always non-nullable).